Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulesync 7.3.0 #356

Merged
merged 21 commits into from
Mar 16, 2024
Merged

Modulesync 7.3.0 #356

merged 21 commits into from
Mar 16, 2024

Conversation

siegy22
Copy link
Contributor

@siegy22 siegy22 commented Mar 15, 2024

Pull Request (PR) description

Based on #322. The target is to fix GitHub actions, and also test against newer EL versions.

Spent hours trying to debug the GitHub actions because on my local machine running bundle exec beaker always worked 😢
See 9dbbdf6 for what I found out.

@siegy22 siegy22 changed the title Fix gha Fix GitHub actions Mar 15, 2024
Copy link
Contributor

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the time invested, looks good to me :)

@zilchms zilchms changed the title Fix GitHub actions Add Rocky 8 and 9 support Mar 16, 2024
@zilchms zilchms changed the title Add Rocky 8 and 9 support Add Rocky 8 and 9 support and fix acceptance tests Mar 16, 2024
@zilchms zilchms added the enhancement New feature or request label Mar 16, 2024
@zilchms
Copy link
Contributor

zilchms commented Mar 16, 2024

@siegy22 , can I get you to add the rocky support in a separate PR? That way we can handle labeling and stuff get properly done :) I am going to have to drop the ubuntu support commit in a separate PR too, so I am going to remove that commit from the modulesync PR. After that you should rebase your testfixes to the updated branch :)

Apparently running on GitHub actions doesn't support a filesystem that will
correctly handle file locks? Let's use the Splunk provided option to be able for
Splunkd to start.
@siegy22 siegy22 changed the title Add Rocky 8 and 9 support and fix acceptance tests Fix acceptance tests Mar 16, 2024
@siegy22
Copy link
Contributor Author

siegy22 commented Mar 16, 2024

@zilchms There you go!

@zilchms zilchms merged commit 46ff800 into voxpupuli:master Mar 16, 2024
6 checks passed
@zilchms zilchms changed the title Fix acceptance tests Modulesync 7.3.0 Mar 16, 2024
@zilchms zilchms added modulesync and removed enhancement New feature or request labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants