Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing badges #66

Merged
merged 3 commits into from
Nov 1, 2016
Merged

Add missing badges #66

merged 3 commits into from
Nov 1, 2016

Conversation

dhoppe
Copy link
Member

@dhoppe dhoppe commented Oct 31, 2016

No description provided.

* Installs the Splunk/Forwarder package and manages their config files. It does
not purge them by default.
* The module will set up both Splunk and Splunkforwarder to run as the 'root'
user on POSIX platforms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for wrapping lines in the README.md? I didn't realize that was "a thing"

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the Markdown lint tool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference would be to disable this check - maintaining documentation with line breaks is just a PITA - not sure what the wider preference is though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, because I changed this for almost every module and this is more readable in text editors like VIM.

@bastelfreak What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should honour the linter here. My vim makes automatic linebreaks after X chars, that needs to be configured but works fine.

@crayfishx which parts do you recognize as PITA?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding three words to a sentence means I then need to manually adjust all the line spacing for the rest of the paragraphs.... yeah I know there are editor plugins that can do this, I just don't see the point in enforcing this - I quite like text to wrap to the length I choose by resizing my terminal window.... maybe it's just me ;-)

@bastelfreak bastelfreak merged commit 1f37b5a into voxpupuli:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants