splunk_config: Only load other splunk types #95
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `splunk_config` type needs to load the other `splunk*` types for purging. It did this by requiring all of the other ruby files in the same directory, which, on the client side, includes types from other modules. This resulted in type redefinition warnings during the agent run, and even failures in cases where the other types included libraries that were not present on the system: ``` Info: Redefining anchor in Puppet::Type Info: Redefining file_line in Puppet::Type Info: Redefining firewall in Puppet::Type Info: Redefining firewallchain in Puppet::Type Info: Redefining ini_setting in Puppet::Type Error: Could not autoload puppet/provider/make_server_update/ruby: cannot load such file -- net/http/post/multipart Error: Could not autoload puppet/type/splunk_config: Could not autoload puppet/provider/make_server_update/ruby ``` This changes the `splunk_config` type to only load other type source files that start with 'splunk'. Even better still would be to only load an explicit list of types source files rather than using a glob, but I'll leave that choice to the module maintainer.
dhoppe
approved these changes
Mar 5, 2017
|
@iamjamestl Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
splunk_configtype needs to load the othersplunk*types forpurging. It did this by requiring all of the other ruby files in the
same directory, which, on the client side, includes types from other
modules. This resulted in type redefinition warnings during the agent
run, and even failures in cases where the other types included libraries
that were not present on the system:
This changes the
splunk_configtype to only load other type sourcefiles that start with 'splunk'. Even better still would be to only load
an explicit list of types source files rather than using a glob, but
I'll leave that choice to the module maintainer.
Closes #86