types: Fix purging when section contains '//' #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis did not run. |
jameslikeslinux
force-pushed
the
fix-purge-inputs
branch
from
eeabdb4 to
e1031c0
Compare
|
Fixed--just minor rubocop violations. |
A change made in 0fe96f7 to support section headings of the form: ``` foo://bar ``` broke purging, where the underlying inifile type generates resources with titles like: ``` section/setting ``` When a resource is generated with a title 'foo://bar/setting', the setting name is not parsed. This is the case with inputs which often take on the form: ``` [monitor:///var/log/messages] setting1 = value1 setting2 = value2 ``` The result is an error message: "Error: /Stage[main]/Splunk::Params/Splunk_config[splunk]: Failed to generate additional resources using 'generate': Got nil value for setting." See: issue voxpupuli#69. This change looks for additional slashes beyond the '://' and will parse out the following string as the setting name. This is not very satisfying because it could break a theoretical section name containing extra slashes, but I have not come across that before, and the `[monitor:///../../../]` case is **very** common.
jameslikeslinux
force-pushed
the
fix-purge-inputs
branch
from
e1031c0 to
f783b0f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change made in 0fe96f7 to support section headings of the form:
broke purging, where the underlying inifile type generates resources
with titles like:
When a resource is generated with a title 'foo://bar/setting', the
setting name is not parsed. This is the case with inputs which often
take on the form:
The result is an error message: "Error:
/Stage[main]/Splunk::Params/Splunk_config[splunk]: Failed to generate
additional resources using 'generate': Got nil value for setting." See:
issue #69.
This change looks for additional slashes beyond the '://' and will
parse out the following string as the setting name.
This is not very satisfying because it could break a theoretical section
name containing extra slashes, but I have not come across that before,
and the
[monitor:///../../../]case is very common.