Support puppet 6.5 #106
Merged
Support puppet 6.5 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binford2k
requested changes
Jul 6, 2019
Longer term, it'd be better to use a public interface, but for now, code for the changes to the private `validate_manifest` method made in puppetlabs/puppet#6909 See https://tickets.puppetlabs.com/browse/PUP-8984
Good catch. Locally, I had seen the tests fail and then pass after my change. |
binford2k
approved these changes
Jul 6, 2019
alexjfisher
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longer term, it'd be better to use a public interface, but for now, code
for the changes to the private
validate_manifestmethod made inpuppetlabs/puppet#6909
See https://tickets.puppetlabs.com/browse/PUP-8984