Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken unit tests #110

Closed
wants to merge 1 commit into from
Closed

fix broken unit tests #110

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

Failures on master before this fix:

Failures:

  1) PuppetSyntax::Templates should continue after finding an error in the first file
     Failure/Error: expect(res[1]).to match(/2: warning: found = in conditional/)
     
       expected "/home/bastelfreak/puppet-syntax/spec/fixtures/test_module/templates/fail_warning.erb:2: warning: found `= literal' in conditional, should be ==\n" to match /2: warning: found = in conditional/
       Diff:
       @@ -1,2 +1,2 @@
       -/2: warning: found = in conditional/
       +/home/bastelfreak/puppet-syntax/spec/fixtures/test_module/templates/fail_warning.erb:2: warning: found `= literal' in conditional, should be ==
       
     # ./spec/puppet-syntax/templates_spec.rb:53:in `block (2 levels) in <top (required)>'

@bastelfreak bastelfreak added the bug Something isn't working label Oct 4, 2019
alexjfisher
alexjfisher reviewed Oct 4, 2019
View reviewed changes
spec/puppet-syntax/templates_spec.rb
@@ -50,7 +50,7 @@

expect(res.size).to eq(2)
expect(res[0]).to match(/2: syntax error, unexpected/)
expect(res[1]).to match(/2: warning: found = in conditional/)
expect(res[1]).to match(/2: warning: found.*=.* in conditional/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the error message based on ruby version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes.

@bastelfreak
Copy link
Member Author

superseeded by #111

@bastelfreak bastelfreak closed this Oct 4, 2019
@bastelfreak bastelfreak deleted the fix branch October 4, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @alexjfisher