Drop legacy code to support Puppet < 5 and Ruby < 2.4 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5962cd added this check but now we can assume people are using at least puppetlabs_spec_helper 0.8.0.
Since Puppet 5 is now required so this should be enabled unconditionally.
This was only relevant on Puppet 3.2 through 3.8 which is no longer supported.
Merged
binford2k
added a commit
to binford2k/puppetlabs_spec_helper
that referenced
this pull request
Feb 15, 2022
This is outdated and no longer supported by [puppet-syntax](voxpupuli/puppet-syntax#120)
chelnak
pushed a commit
to binford2k/puppetlabs_spec_helper
that referenced
this pull request
Oct 24, 2022
This is outdated and no longer supported by [puppet-syntax](voxpupuli/puppet-syntax#120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
824ecce added Puppet as a gem dependency which means that it no longer works with older versions. This means we can drop
future_parserandapp_managementsettings as well as various compatibility code sections. It also removes a check that ensures puppetlabs_spec_helper >= 0.8.0 is used.