Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERB handling #129

Closed
wants to merge 1 commit into from
Closed

Update ERB handling #129

wants to merge 1 commit into from

Conversation

akerl
Copy link
Contributor

@akerl akerl commented Mar 10, 2022

This resolves the deprecation warnings I'm seeing with puppet-syntax:

WARNINGS:
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/Users/akerl/.rbenv/versions/3.1.1/lib/ruby/gems/3.1.0/gems/puppet-syntax-3.1.0/lib/puppet-syntax/templates.rb:72: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

@ekohl
Copy link
Member

ekohl commented Mar 11, 2022

It looks like this is still using Travis CI and not GitHub Actions. I'm first going to send a PR to convert it so we have CI to confirm whether it works or not.

@ekohl
Copy link
Member

ekohl commented Mar 11, 2022

#130 is failing for some reason, but I don't know why.

@akerl
Copy link
Contributor Author

akerl commented Apr 18, 2022

Any chance of merging this prior to the GH Actions change, if that’s a deeper rabbit hole?

@smortex
Copy link
Member

smortex commented Apr 19, 2022

@akerl can you please rebase this on top of #130?

From your local repository, on the patch-1 branch:

git remote add ekohl git@github.com:ekohl/puppet-syntax.git
git fetch ekohl
git rebase ekohl/gha
git push -f

@ekohl
Copy link
Member

ekohl commented Apr 19, 2022

I've included the patch in #130 now, let's see what that brings.

@ekohl
Copy link
Member

ekohl commented Apr 19, 2022

Obsoleted by #130 where I included this with an additional fix for Ruby < 2.6. Thanks for pointing this out!

@ekohl ekohl closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants