-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Debian 12 #357
Support Debian 12 #357
Conversation
Needs a bit more testing as enabling with: class{'systemd':
manage_resolved => true,
use_stub_resolver => true,
} I lost DNS. ( fixed by reboot and now running and using systemd-resolved ) |
Understood - not relevent. |
LGTM. We should think about, installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tuxmea Did you try migrating with this - I do loose initially which I never really understood? |
FYI: voxpupuli/puppet_metadata#102 would add Debian 12 to acceptance tests using distro packages so you at least have Puppet 7 to test with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we apply this with voxpupuli/modulesync_config#855 we should have at least some acceptance test.
In particular with Debian 11->12 systemd-resolved is now a sub package that must be installed.
I took the liberty of rebasing this. |
spec/acceptance/resolved_spec.rb
Outdated
# RedHat 7, 9, Debian 12 and newer installs package first run before fact $facts['internal_services'] is set | ||
if (fact('os.release.major') != '8' && (fact('os.family') == 'RedHat')) || | ||
((fact('os.name') == 'Debian' && fact('os.release.major').to_i >= 12)) | ||
apply_manifest(pp, catch_failures: true) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For systemd-networkd I extracted this to a separate variable:
has_package = fact('os.family') == 'RedHat' |
Then I reused it to check if the package is installed:
it { expect(package('systemd-networkd')).to be_installed } if has_package |
Pull Request (PR) description
In particular with Debian 11->12 systemd-resolved is now a sub package
that must be installed.
Clearly there are no tests running for Debian 12 yet.