-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian 12 #102
Add Debian 12 #102
Conversation
39fd8c7
to
716d390
Compare
@@ -32,6 +32,7 @@ class OperatingSystem | |||
# https://wiki.debian.org/DebianReleases | |||
'Debian' => { | |||
# TODO: EOL is standard support, not the extended life cycle | |||
'12' => nil, # '~2026', | |||
'11' => nil, # '~2024', | |||
'10' => nil, # '~2022', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, 10 is EOL by now. should we add the date now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we should do that in another PR (actually it was 2022-09-10 and we missed it) :D
https://endoflife.date/debian
In the past we waited with adding a new OS until puppet provides AIO packages for the platform. I don't mind adding Debian 12 already but then we need to ensure that we use the distro packages instead. |
They still… Okay… How do I tell it to use distro packages, is that even in this repo? Do I really want to know? |
It is in this repository: 0dcad53 is how it was done for Arch Linux. It was in my wish list to support this at some point. We probably need some special casing here: puppet_metadata/lib/puppet_metadata/github_actions.rb Lines 63 to 67 in 5ffbf79
We probably need something for Fedora too there. |
#104 does that. And I've taken the liberty of taking your PR and rebase it on top of it, doing the same for Debian 12. |
Testing it out in voxpupuli/puppet-example#37. |
It includes #104 but Fedora actually has an issue where |
# The operating system release version | ||
# | ||
# @return [Optional[Integer]] The Puppet major version, if any | ||
def os_release_puppet_version(operatingsystem, release) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo for me: add arch linux here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's rolling I'm not sure if that's desirable.
When there is no AIO build available, it is possible to test the OS using the distribution provided package. Since these aren't rolling releases, it includes the Puppet version in the context. Not in the name, to keep it consistent.
While there aren't any AIO builds, this allows testing the platform.
Dependencies to merge & release this: |
No description provided.