disable by default and deprecate dpkg "options" parameter #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Looks like the tests need to be updated as well. |
of course, will quickfix now |
unattended-upgrades does *not* need special configuration to `dpkg` for proper operation. It handles those itself. All that parameter does is changes the `dpkg` configuration for *other* `dpkg` runs. This will, for example, affect major upgrades, typically done by hand, and not unattended-upgrades, which was *not* designed for that purpose. In those cases, unsuspecting users will see their old configuration file versions silently kept in place, which most definitely *will* break things on upgrade, rather noisily in the end. People unfamiliar with this mechanism will have a hard time figuring out what has happened, and while recovery is possible, it is tricky without special tooling. I wrote such a tool here: https://gitlab.com/anarcat/koumbit-scripts/-/blob/master/vps/clean_conflicts ... but it not well known and definitely not shipped with Debian by default. While it is nice that the unattended-upgrades module allows users to change dpkg options, this can be more easily (and directly) done with the `apt::conf` parameter in the first place. This also marks the feature as deprecated. Once a proper deprecation delay has passed, the code can be removed (with, for example, PR voxpupuli#190).
anarcat
force-pushed
the
deprecate-options
branch
from
338d44c
to
db623cd
Compare
bastelfreak
approved these changes
Aug 19, 2021
kenyon
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unattended-upgrades does not need special configuration to
dpkgfor proper operation. It handles those itself. All that parameter does
is changes the
dpkgconfiguration for otherdpkgruns.This will, for example, affect major upgrades, typically done by hand,
and not unattended-upgrades, which was not designed for that
purpose. In those cases, unsuspecting users will see their old
configuration file versions silently kept in place, which most
definitely will break things on upgrade, rather noisily in the end.
People unfamiliar with this mechanism will have a hard time figuring
out what has happened, and while recovery is possible, it is tricky
without special tooling. I wrote such a tool here:
https://gitlab.com/anarcat/koumbit-scripts/-/blob/master/vps/clean_conflicts
... but it not well known and definitely not shipped with Debian by
default.
While it is nice that the unattended-upgrades module allows users to
change dpkg options, this can be more easily (and directly) done with
the
apt::confparameter in the first place.This also marks the feature as deprecated. Once a proper deprecation
delay has passed, the code can be removed (with, for example, PR #190).
Replaces #190 for now.