-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Debian 11 #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem to unexpectedly change the behavior for Debian Buster.
Please update your code to keep the original behavior in place (unless it was broken?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add Debian 11 to the metadata.json
@smortex Not sure what adjustments you are referring to. In glancing at the code, and some old commits for adding new OSes, the changes I made seemed to be correct. It looks like this module has default origins on Debian only for the current release, and older releases get security origins by default. Buster is now an older release, as of a few weeks ago. Bullseye is |
Ah! All good then, sorry for the confusion 😄. I have just merged a bunch of PR to drop old releases and extend the test suite. Do you mind rebasing on top of it and fixing conflicts? From your working directory:
Thanks! |
- Also moves Buster into the default settings area implicitly, since Buster is now in oldstable.
Should be good then. Also just a side note, there are more references to old OS in other_debians_spec. Since you just cleaned stuff out in the other PRs, I figured I would let you know. I don't want to bother in this PR, since it's slightly unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is no strong policy here, when we "drop support", we stop making sure everything works and we are able to nuke legacy code. This rarely happen at the same time, so next major release which "drop support" will in fact probably work as well for legacy releases, but removing the corresponding code is a following move. If you want to assist in this, feel free to send more PRs 😃 Thanks! |
In voxpupuli#193, buster was renamed to bullseye, which caused a regression for buster: the main "Debian" origin would now be removed. This commit restores that origin for the default Debian case.
In voxpupuli#193, buster was renamed to bullseye, which caused a regression for buster: the main "Debian" origin would now be removed. This commit restores that origin for the default Debian case.
I believe this will work.
Closes #187