Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 11 #193

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add support for Debian 11 #193

merged 1 commit into from
Sep 2, 2021

Conversation

sboyd-m
Copy link
Contributor

@sboyd-m sboyd-m commented Sep 1, 2021

I believe this will work.

Closes #187

@sboyd-m sboyd-m marked this pull request as ready for review September 1, 2021 22:01
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to unexpectedly change the behavior for Debian Buster.

Please update your code to keep the original behavior in place (unless it was broken?)

@smortex smortex changed the title Debian Bullseye is now stable Add support for Debian 11 Sep 2, 2021
@smortex smortex added the enhancement New feature or request label Sep 2, 2021
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add Debian 11 to the metadata.json

@sboyd-m
Copy link
Contributor Author

sboyd-m commented Sep 2, 2021

@smortex Not sure what adjustments you are referring to. In glancing at the code, and some old commits for adding new OSes, the changes I made seemed to be correct. It looks like this module has default origins on Debian only for the current release, and older releases get security origins by default. Buster is now an older release, as of a few weeks ago. Bullseye is stable, and buster is oldstable. I'm happy to just change it back of course, but the code as I see it ought to be the way it is in the PR.

@smortex
Copy link
Member

smortex commented Sep 2, 2021

Ah! All good then, sorry for the confusion 😄.

I have just merged a bunch of PR to drop old releases and extend the test suite. Do you mind rebasing on top of it and fixing conflicts?

From your working directory:

git fetch origin         # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
# -- Here git will complain about the conflict, open metadata.json, fix the conflict, then
git add metadata.json    # Tell git this file is now fixed
git rebase --continue    # Ask git to continue it work
# -- End of conflict management
git push -f              # Send the changes (-f is required because we re-wrote history)

Thanks!

- Also moves Buster into the default settings area implicitly, since
  Buster is now in oldstable.
@sboyd-m
Copy link
Contributor Author

sboyd-m commented Sep 2, 2021

Should be good then.

Also just a side note, there are more references to old OS in other_debians_spec. Since you just cleaned stuff out in the other PRs, I figured I would let you know. I don't want to bother in this PR, since it's slightly unrelated.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex merged commit 78154df into voxpupuli:master Sep 2, 2021
@smortex
Copy link
Member

smortex commented Sep 2, 2021

Also just a side note, there are more references to old OS in other_debians_spec. Since you just cleaned stuff out in the other PRs, I figured I would let you know. I don't want to bother in this PR, since it's slightly unrelated.

There is no strong policy here, when we "drop support", we stop making sure everything works and we are able to nuke legacy code. This rarely happen at the same time, so next major release which "drop support" will in fact probably work as well for legacy releases, but removing the corresponding code is a following move.

If you want to assist in this, feel free to send more PRs 😃

Thanks!

kenyon added a commit to kenyon/puppet-unattended_upgrades that referenced this pull request Oct 4, 2021
In voxpupuli#193, buster was renamed to bullseye, which caused a regression for
buster: the main "Debian" origin would now be removed. This commit
restores that origin for the default Debian case.
kenyon added a commit to kenyon/puppet-unattended_upgrades that referenced this pull request Oct 4, 2021
In voxpupuli#193, buster was renamed to bullseye, which caused a regression for
buster: the main "Debian" origin would now be removed. This commit
restores that origin for the default Debian case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 11 changes name of security suite
3 participants