Replace legacy Allowed-Origins with Origins-Pattern on all distros #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure people don't trip over old configs, let's validate that the given origins comply with the current format. Straight-up removed legacy origins as, after checking, none of the Debian-based distributions (and thus their derivates) we support still require legacy-style origin definition. This is a breaking change.
towo
force-pushed
the
fix/ubuntu-legacy
branch
from
d15a763
to
2d03650
Compare
* Leftover legacy formats in tests removed. * A typo in the ESM repositories fixed. * Use correct test specs.
towo
force-pushed
the
fix/ubuntu-legacy
branch
from
8666f5b
to
aea305f
Compare
kenyon
approved these changes
Nov 3, 2021
|
Looks good, maybe a more descriptive PR title for the changelog? |
bastelfreak
reviewed
Nov 3, 2021
bastelfreak
reviewed
Nov 3, 2021
metadata.json
Outdated
| @@ -27,7 +27,8 @@ | |||
| "operatingsystem": "Ubuntu", | |||
| "operatingsystemrelease": [ | |||
| "18.04", | |||
| "20.04" | |||
| "20.04", | |||
| "21.04" | |||
There was a problem hiding this comment.
do you have a ubuntu 21.04 box around to provide factsets for https://github.com/voxpupuli/facterdb ? Also please create a new PR that adds 21.04 here. That allows us to put the two PRs in different sections (breaking change vs enhancement)
towo
changed the title
To be fair… I didn't even notice I forgot to change the PR title from the branch name. ta. :) |
|
You might consider updating the README. Currently documentation there still references the now-removed |
kenyon
added a commit
that referenced
this pull request
Nov 24, 2021
`legacy_origin` was removed in #204.
|
Thanks, I made #205 for updating the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Since all Debian-based distributions VP officially supports feature a version of
unattended-upgradethat's compatible with theOrigins-Patternvariable, this PR gets rid of the legacy configuration altogether.To ensure that no one gets unexpected surprises by this, I've added input validation for
$originsto ensure it's only in the new-style format and hopefully avoid exploding in people's faces; nevertheless, since this potentially breaks existing configurations, it should probably be combined with a major version bump.