Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default LinuxMint origins so they pass validation #218

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Fix default LinuxMint origins so they pass validation #218

merged 2 commits into from
Oct 25, 2022

Conversation

djmofcourse
Copy link
Contributor

Pull Request (PR) description

The default origins for "LinuxMint" do not pass validation and cause an error when puppet agent runs:

Error while evaluating a Function Call, Class[Unattended_upgrades]: parameter 'origins' index 0 expects a match for Unattended_upgrades::Origin = Pattern[/^(origin|codename|label|site|suite|component|archive|[oalcn])=[^,]+(,(origin|codename|label|site|suite|component|archive|[oalcn])=[^,]+)*/], got '${distro_id}:${distro_codename}-security'

This change tweaks the origin line to pass validation, allowing puppet agent runs to succeed.

This Pull Request (PR) fixes the following issues

n/a

The default origins for "LinuxMint" do not pass validation
(`Unattended_upgrades::Origin` type), and cause an error:

```
Error while evaluating a Function Call, Class[Unattended_upgrades]: parameter 'origins' index 0 expects a match for Unattended_upgrades::Origin = Pattern[/^(origin|codename|label|site|suite|component|archive|[oalcn])=[^,]+(,(origin|codename|label|site|suite|component|archive|[oalcn])=[^,]+)*/], got '${distro_id}:${distro_codename}-security'
```

This change tweaks the origin line to pass validation.
manifests/params.pp Outdated Show resolved Hide resolved
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@ekohl ekohl merged commit 07c90d7 into voxpupuli:master Oct 25, 2022
@djmofcourse djmofcourse deleted the fix/linux-mint-origin-format branch October 25, 2022 12:20
@bastelfreak bastelfreak added the bug Something isn't working label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants