Add optional notify_update parameter #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment we make sure apt_update is ran before any packages is installed with the following:
Exec['apt_update'] -> Package <| |>
With this statement, a dependency cycle is created:
(Exec[apt_update] => Package[unattended-upgrades] => Apt::Conf[unattended-upgrades] => Apt::Setting[conf-unattended-upgrades] => File[/etc/apt/apt.conf.d/50unattended-upgrades] => Class[Apt::Update] => Exec[apt_update])
It's possible to call apt::conf (v2.2.0 or later) and not run apt_update by specifying 'notify_update => false'. This avoids our dependency problem.
This PR adds an optional parameter 'notify_update' to init.pp (if the parameter is not specified, the defaults applies and apt_update is notified). The parameter can be undef (default), true or false.