-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Ubuntu updates #62
Conversation
raoulbhatia
commented
May 29, 2016
- Ubuntu: Add 16.04 Xenail Xerus and 16.10 Yakkety Yak.
- Ubuntu: Issue EOL warning for unsupported release.
- Tests: Misc spec cleanup
@alexjfisher I am not sure how to properly test for the warnings. Maybe you can let me know how to properly do the "acceptance" testing? |
thanks for the PR, looks good so far! 👍 |
@raoulbhatia I believe you're looking for this matcher re: warning testing. https://www.relishapp.com/rspec/rspec-expectations/docs/built-in-matchers/output-matcher |
@jyaworski I will not have time in the near future to implement those output matchers. |
Tested https://github.com/voxpupuli/puppet-unattended_upgrades v2.0.0 on Xenial and it seems to work. |
] | ||
|
||
} | ||
'trusty', 'utopic', 'vivid', 'wily': { | ||
'trusty', 'wily': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a particular reason you're dropping utopic and vivid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igalic Ubuntu utopic [1] and vivid [2] have reached EOL and are / will be removed from the regular mirrors and migrated to the archive repositories.
The deprecation warning that is also part of the pull request will hint the user to this fact.
Do you see valid use cases for still supporting utopic and vivid?
Raoul
[1] https://lists.ubuntu.com/archives/ubuntu-announce/2015-July/000198.html
[2] https://lists.ubuntu.com/archives/ubuntu-announce/2016-January/000203.html
@raoulbhatia can you rebase on the current master? |
eccd577
to
3f110c2
Compare
@jyaworski done |