Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ubuntu updates #62

Merged
merged 3 commits into from
Sep 12, 2016
Merged

[WIP] Ubuntu updates #62

merged 3 commits into from
Sep 12, 2016

Conversation

raoulbhatia
Copy link
Contributor

  • Ubuntu: Add 16.04 Xenail Xerus and 16.10 Yakkety Yak.
  • Ubuntu: Issue EOL warning for unsupported release.
  • Tests: Misc spec cleanup

@raoulbhatia
Copy link
Contributor Author

@alexjfisher I am not sure how to properly test for the warnings. Maybe you can let me know how to properly do the "acceptance" testing?

@bastelfreak
Copy link
Member

thanks for the PR, looks good so far! 👍

@jyaworski
Copy link
Member

@raoulbhatia I believe you're looking for this matcher re: warning testing.

https://www.relishapp.com/rspec/rspec-expectations/docs/built-in-matchers/output-matcher

@raoulbhatia
Copy link
Contributor Author

@jyaworski I will not have time in the near future to implement those output matchers.
Happy if somebody would step in to help adding such a test.

@erezny
Copy link

erezny commented Jun 10, 2016

Tested https://github.com/voxpupuli/puppet-unattended_upgrades v2.0.0 on Xenial and it seems to work.

@juniorsysadmin juniorsysadmin added needs-help Extra attention is needed needs-tests tests-fail enhancement New feature or request and removed tests-fail labels Jun 12, 2016
]

}
'trusty', 'utopic', 'vivid', 'wily': {
'trusty', 'wily': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a particular reason you're dropping utopic and vivid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igalic Ubuntu utopic [1] and vivid [2] have reached EOL and are / will be removed from the regular mirrors and migrated to the archive repositories.

The deprecation warning that is also part of the pull request will hint the user to this fact.

Do you see valid use cases for still supporting utopic and vivid?

Raoul

[1] https://lists.ubuntu.com/archives/ubuntu-announce/2015-July/000198.html
[2] https://lists.ubuntu.com/archives/ubuntu-announce/2016-January/000203.html

@jyaworski
Copy link
Member

@raoulbhatia can you rebase on the current master?

@raoulbhatia
Copy link
Contributor Author

@jyaworski done

@jyaworski jyaworski merged commit f02afe2 into voxpupuli:master Sep 12, 2016
@raoulbhatia raoulbhatia deleted the ubuntu branch September 12, 2016 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-help Extra attention is needed needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants