move defaults to class so that puppet-strings can build better docs #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I also updated the defaults for arrays to []
* I also updated the defaults for hash to {}
* Add some types to make init.pp a bit more readable
|
Do be honest i don't really like this patch, I think that puppet-strings should be able to read defaults from hiera, Ideally displaying the default for the various OS's. As the puppet labs style guide suggests one put defaults in hiera i would even go so far as to call it a bug. further by puppet defaults in the class manifest it prevents you from doing things like (see diffs for real example) common.yamlunbound::service_name: unbound
unbound::restart_cmd: "systemctl restart %{lookup('unbound::service_name')}"OpenBSD.yaml (i.e. we dont need to redefine service_name)unbound::restart_cmd: "service restart %{lookup('unbound::service_name')}" |
|
I would also b e happy with puppet-strings could do that. I pinged in puppetlabs/puppet-strings#250 again |
bastelfreak
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Currently puppet-strings is unable to read defaults from hiera as such move the defaults back to init.pp