Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undefined variable access #49

Closed
wants to merge 3 commits into from

Conversation

dominikschulz
Copy link

This PR tries to work around some issues with strict_variables = true

@carlossg
Copy link
Member

carlossg commented Jul 8, 2015

lint is failing

schedule was added in #46 mentioning that it shouldn't be in the parameters

@dominikschulz
Copy link
Author

I'll fix the lint check and check on the metaparams for the future parser. But this parameter didn't work for us with the future parser enabled.

@carlossg
Copy link
Member

ping @robbat2

@BobVincentatNCRdotcom
Copy link

I think the problem is that all branches of a selector are evaluated. I've submitted another patch that converts the selector to an if statement, and it passes tests.

@robbat2
Copy link

robbat2 commented Nov 8, 2015

If you don't pass schedule down to the resource, the resource is always applied, which is not desired.

Has the lint changed, that metaparams must now be declared as well?

@BobVincentatNCRdotcom
Copy link

See #64 for an approach that passes tests.

@robbat2
Copy link

robbat2 commented Nov 9, 2015

+1 on #64

@BobVincentatNCRdotcom
Copy link

Better approach in #66

@carlossg
Copy link
Member

carlossg commented Mar 1, 2016

closing for #66

@carlossg carlossg closed this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants