-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove undefined variable access #49
Conversation
lint is failing schedule was added in #46 mentioning that it shouldn't be in the parameters |
I'll fix the lint check and check on the metaparams for the future parser. But this parameter didn't work for us with the future parser enabled. |
ping @robbat2 |
I think the problem is that all branches of a selector are evaluated. I've submitted another patch that converts the selector to an if statement, and it passes tests. |
If you don't pass schedule down to the resource, the resource is always applied, which is not desired. Has the lint changed, that metaparams must now be declared as well? |
See #64 for an approach that passes tests. |
+1 on #64 |
Better approach in #66 |
closing for #66 |
This PR tries to work around some issues with strict_variables = true