Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EPEL repo IDs #81

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

lamawithonel
Copy link

Puppet's yumrepo type's name parameter maps to the repositoryid
attribute of concrete Yum repos, whereas the yumrepo type's descr
parameter maps to the concrete name attribute. Prior to this commit
the two were confused in the EPEL repository data, causing parse errors.
This commit corrects this error, changing the name parameter keys to
descr.

Fixes #53

Puppet's `yumrepo` type's `name` parameter maps to the `repositoryid`
attribute of concrete Yum repos, whereas the `yumrepo` type's `descr`
parameter maps to the concrete `name` attribute.  Prior to this commit
the two were confused in the EPEL repository data, causing parse errors.
This commit corrects this error, changing the `name` parameter keys to
`descr`.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct and I've seen similar issues with the yum repo type and names.

@bastelfreak bastelfreak added the bug Something isn't working label Dec 5, 2017
@bastelfreak
Copy link
Member

Thanks @lamawithonel !

@bastelfreak bastelfreak merged commit e230f0a into voxpupuli:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants