This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Fix TFS checks and add more fixtures/tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling a1865eb on dhollinger:add_more_fixtures into ** on voxpupuli:master**. |
ekohl
approved these changes
Nov 16, 2017
| repo_name: 'puppet-r10k' | ||
| ) | ||
| end | ||
| it 'doesn\'t populate repo_user' do |
There was a problem hiding this comment.
I think you cn also write it 'doesn\'t pupulate repo_user', unless: service =~ %r{github|gitlab} do
alexjfisher
reviewed
Nov 16, 2017
| @@ -78,7 +78,8 @@ def branch | |||
| when 'stash' | |||
| @data['refChanges'][0]['refId'].sub('refs/heads/', '') | |||
| when 'bitbucket' | |||
| @data['push']['changes'][0]['new']['name'] | |||
| return @data['push']['changes'][0]['new']['name'] unless deleted? | |||
There was a problem hiding this comment.
Cool, unless deleted? did work! :)
alexjfisher
approved these changes
Nov 16, 2017
|
Changes Unknown when pulling 2aaa2a7 on dhollinger:add_more_fixtures into ** on voxpupuli:master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleted?check