This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
Allow github to send form-urlencoded payloads and bug fix in webrick_opts #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
suggested changes
Feb 12, 2018
There was a problem hiding this comment.
Looks like a great addition. There are some rubocop failures, could you take a look at those and correct them before we merge this?
Additionally, in the future, it would be easier to have bugfixes and enhancements separated into separate PRs.
Otherwise, looks good to me!
|
Great! Yeah sorry first time contributing to open source. Will get on those. |
dhollinger
approved these changes
Feb 12, 2018
|
Thanks! Merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.