Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Clarify that mco is not a hard requirement #47

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Conversation

binford2k
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 4, 2018

Coverage Status

Coverage remained the same at 50.746% when pulling 06049e6 on binford2k-patch-2 into 78bd9a8 on master.

@qralston
Copy link

qralston commented Apr 4, 2018

I think this change helps clarify that mco is only a requirement if you specially want to use mco to update multiple masters, and that nothing stops you from using some other mechanism to update multiple servers.

@bastelfreak
Copy link
Member

@binford2k @adrienthebo was that label intentional? Otherwise I'm fine with merging it.

@dhollinger
Copy link
Member

Can we get the mcollective-client gem removed as runtime dependency added in this PR?

@qralston
Copy link

qralston commented Apr 4, 2018

Can we get the mcollective-client gem removed as runtime dependency added in this PR?

+1 to this.

I don't want to install the mcollective-client gem if I don't need it, because it attempts to overwrite /opt/puppetlabs/puppet/bin/mco from the puppet-agent RPM package, which will then cause rpm --verify puppet-agent to throw checksum errors for /opt/puppetlabs/puppet/bin/mco.

@dhollinger
Copy link
Member

@binford2k we'll have to add the mcollective-client gem as a development dependency as the tests utilize mcollective (sorry, didn't even think about that).

@dhollinger dhollinger merged commit 15e7223 into master Apr 5, 2018
@binford2k binford2k deleted the binford2k-patch-2 branch April 5, 2018 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants