This repository has been archived by the owner on Jan 29, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Nov 23, 2018
.gitignore
Outdated
@@ -6,3 +6,6 @@ logs/*.log | |||
coverage | |||
Gemfile.lock | |||
.byebug_history | |||
vendor/ | |||
.bundle/ | |||
.vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this, but it is outside the scope of the PR. The vscode stuff is only because I'm using VSCode right now and didn't want to commit my config.
alexjfisher
reviewed
Nov 23, 2018
dhollinger
force-pushed
the
puppet_webhook-75
branch
2 times, most recently
from
November 23, 2018 19:54
5aa4837
to
a0d73fb
Compare
Dan33l
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dhollinger
force-pushed
the
puppet_webhook-75
branch
from
November 23, 2018 21:04
a0d73fb
to
7351644
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this doesn't add any actual workers yet (more work needs to be done there). This just adds the gem and the webui in config.ru