Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

Add Sidekiq support #76

Merged
merged 3 commits into from
Nov 23, 2018
Merged

Conversation

dhollinger
Copy link
Member

this doesn't add any actual workers yet (more work needs to be done there). This just adds the gem and the webui in config.ru

.gitignore Outdated
@@ -6,3 +6,6 @@ logs/*.log
coverage
Gemfile.lock
.byebug_history
vendor/
.bundle/
.vscode/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this, but it is outside the scope of the PR. The vscode stuff is only because I'm using VSCode right now and didn't want to commit my config.

config.ru Outdated Show resolved Hide resolved
@dhollinger dhollinger force-pushed the puppet_webhook-75 branch 2 times, most recently from 5aa4837 to a0d73fb Compare November 23, 2018 19:54
@coveralls
Copy link

coveralls commented Nov 23, 2018

Coverage Status

Coverage remained the same at 54.494% when pulling 7351644 on dhollinger:puppet_webhook-75 into 9072559 on voxpupuli:master.

@voxpupuli voxpupuli deleted a comment Nov 23, 2018
@voxpupuli voxpupuli deleted a comment Nov 23, 2018
@voxpupuli voxpupuli deleted a comment Nov 23, 2018
Copy link
Member

@Dan33l Dan33l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhollinger dhollinger merged commit ecf9d56 into voxpupuli:master Nov 23, 2018
@dhollinger dhollinger deleted the puppet_webhook-75 branch November 23, 2018 21:08
@dhollinger dhollinger mentioned this pull request Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants