Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save CI status as PR attribute #162

Merged
merged 2 commits into from
May 2, 2020
Merged

Save CI status as PR attribute #162

merged 2 commits into from
May 2, 2020

Conversation

bastelfreak
Copy link
Member

This will be a series of PRs:

  • Save combined CI status as pull_request attribute
  • Use that to validate if we should a comment/label about CI failures
  • Not only set label/comment if CI is broken, but if the state changes (use saved_changes)

@bastelfreak bastelfreak added enhancement New feature or request backend/eventhandler How incoming data is handled backend/poll-engine How we poll data and handle it labels May 1, 2020
@bastelfreak bastelfreak added this to the travis integration milestone May 1, 2020
@bastelfreak bastelfreak self-assigned this May 1, 2020
bastelfreak added 2 commits May 1, 2020 18:55
@bastelfreak
Save CI status as PR attribute
d845b5d
@bastelfreak
CI: Only add label if status changed to failure
a52f628 
Without this patch, we basically always add a comment if the status is
`failure`, not if the status changed to failure.
@bastelfreak bastelfreak force-pushed the ci-check-failures-2 branch from eaecd49 to a52f628 Compare May 1, 2020 16:55
@bastelfreak
Copy link
Member Author

while thinking of this, how do we handle draft prs? IMO we should not comment on them / label them

@bastelfreak bastelfreak marked this pull request as ready for review May 2, 2020 19:26
@bastelfreak bastelfreak requested a review from a team as a code owner May 2, 2020 19:26
@bastelfreak bastelfreak merged commit f368ec3 into master May 2, 2020
@bastelfreak bastelfreak deleted the ci-check-failures-2 branch May 2, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flipez Flipez Flipez approved these changes

Assignees

@bastelfreak bastelfreak

Labels
backend/eventhandler How incoming data is handled backend/poll-engine How we poll data and handle it enhancement New feature or request
Projects
None yet
Milestone
travis integration
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @Flipez