Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate a PR after every PR update / prevent loops #179

Merged
merged 1 commit into from
May 10, 2020
Merged

Conversation

bastelfreak
Copy link
Member

This change will trigger a sidekiq job after every update on a PR. With
two exceptions: If eligible_for_merge_comment or eligible_for_ci_comment
got updated, we won't triger a job. Those attribute are only set in
the validation methods.

@bastelfreak bastelfreak added the bug Something isn't working label May 8, 2020
@bastelfreak bastelfreak added this to the travis integration milestone May 8, 2020
@bastelfreak bastelfreak requested a review from a team as a code owner May 8, 2020 12:03
@bastelfreak bastelfreak self-assigned this May 8, 2020
This change will trigger a sidekiq job after every update on a PR. With
two exceptions: If eligible_for_merge_comment or eligible_for_ci_comment
got updated, we won't triger a job. Those attribute are *only* set in
the validation methods.
@bastelfreak bastelfreak merged commit 80d95ce into master May 10, 2020
@bastelfreak bastelfreak deleted the fix branch May 10, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants