Move to beaker_puppet_helpers #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Jan 28, 2022
ekohl
force-pushed
the
drop-puppet-install-helper
branch
from
6c3c6d8
to
e2a7a57
Compare
ekohl
force-pushed
the
drop-puppet-install-helper
branch
4 times, most recently
from
1bc1ba8
to
224be75
Compare
ekohl
force-pushed
the
drop-puppet-install-helper
branch
from
224be75
to
bcc94bd
Compare
ekohl
force-pushed
the
drop-puppet-install-helper
branch
from
bcc94bd
to
cfe7a36
Compare
This means the tests run first on the newest Ruby which is likely to be fastest as well.
This ends up dropping beaker-pe, beaker-puppet, beaker-puppet_install_helper and beaker-module_install_helper. This drops support for Puppet Enterprise installations and development builds. However, it does drop the dependency on beaker-pe and greatly simplifies the dependency tree. It also saves maintenance on multiple gems. Another difference is that it now defaults to the puppet collections (instead of puppet6) which means the latest stable release. Installation of modules now happens by creating a module release (using puppet-modulebuilder) and running puppet module install on that. This is a lot faster than the old method because it happens in a single transaction. The new puppet_package_name method can return the correct non-AIO package name. This allows testing on platforms where there is no AIO package available.
ekohl
force-pushed
the
drop-puppet-install-helper
branch
from
cfe7a36
to
d73aa85
Compare
bastelfreak
reviewed
May 5, 2023
Comment on lines
+34
to
+35
| - '2.6' | ||
| - '2.5' |
There was a problem hiding this comment.
I think we should drop 2.5 and 2.6 as well
Suggested change
| - '2.6' | |
| - '2.5' |
bastelfreak
reviewed
May 5, 2023
Comment on lines
+61
to
+62
| - '2.6' | ||
| - '2.5' |
There was a problem hiding this comment.
Suggested change
| - '2.6' | |
| - '2.5' |
This was referenced May 9, 2023
|
implemented in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes a new gem: https://github.com/voxpupuli/beaker_puppet_helpers. Currently that's unpublished and this is untested.
This ends up dropping beaker-pe, beaker-puppet, beaker-puppet_install_helper and beaker-module_install_helper. This drops support for Puppet Enterprise installations and development builds. However, it does drop the dependency on beaker-pe and greatly simplifies the dependency tree. It also saves maintenance on multiple
gems.
Another difference is that it now defaults to the puppet collections (instead of puppet6) which means the latest stable release.
Installation of modules now happens by creating a module release (using puppet-modulebuilder) and running puppet module install on that. This is a lot faster than the old method because it happens in a single transaction.
The new puppet_package_name method can return the correct non-AIO package name. This allows testing on platforms where there is no AIO package available.