-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Tutorials 3, 5, 8 content #6
Conversation
Add tutorials 3, 5, 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit redundancy in tutorial 3 as I also explained about sampling rate in tutorial 1, but I think the explanation here should stay as it does give a more indepth view
Tutorials 3 and 5 are solid, I know we assume that people who use the tutorials have some background knowledge, but it may be helpful to maybe link https://jackschaedler.github.io/circles-sines-signals/sincos.html for those who don't. I used it and it helped me understand these tutorials more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sampling is necessary and covered well here. I also go over 1/f and oscillations in frequency domain in my tutorial 7 maybe we should talk about where oscillations should go, though I feel the sooner its introduced the better
Tutorial 8 looks great!
For tutorial 3, determine if sampling is necessary or redundant. Should I define oscillations in the frequency domaine here as well?
For tutorial 5, the last PAC graph is acting strangely with the switch from Py2 to Py3.
Check validity of tutorial 8 because I wrote it independently of any original Torben-tutorial.
Note: this is in partial fulfillment of #1