Skip to content

updated and added 3 tutorials #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2018
Merged

updated and added 3 tutorials #7

merged 5 commits into from
Oct 2, 2018

Conversation

MichaelTrann
Copy link
Contributor

@MichaelTrann MichaelTrann commented Sep 13, 2018

  1. Electrophysiological Time-Series - added section about sampling, ground vs reference. still need section about burstiness/bands

Event Related Potential Tutorial - fixed syntax errors to make compatible with python 3, overall solid tutorial by Torben, not sure what else to add

Filters - fixed syntax errors to make compatible with python 3, overall solid tutorial by Torben, not sure what else to add

Note: this is in partial fulfillment of #1

Copy link

@ArcadeShrimp ArcadeShrimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good - I dont see any conflicts between our tutorials. Tutorial 1 seems to have an empty 'Neural Oscillations' section at the end

Copy link
Contributor

@sydney-smith sydney-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Electrophysiological Time Series

Looks good and I really like your non-neuro explanation of sampling and use of external resources. However, I think it could benefit from a title at the beginning and a brief introduction about electrophysiological sampling/a short summary of what the tutorial is going to be about. Maybe a little more organization. For example, it's not clear why "Plot the Time Series" is labeled with the number 1. Also, I look forward to reading your added sections on bursting and bands!

2 Event-Related Potential Tutorial

Looks great!

4 Filters

Fix IndexError on ln[7]. I would try to do something like this:
delta_funct[int(len(delta_funct)/2)] = 1
Looks good!

@TomDonoghue TomDonoghue changed the base branch from master to dev October 2, 2018 00:43
@TomDonoghue TomDonoghue merged commit b5647ae into dev Oct 2, 2018
@TomDonoghue TomDonoghue deleted the michael_dev branch October 2, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants