Fix vtsn.len type #269 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
The type of ngx_str_t.len is size_t. So it has occured the type mismatch between vtsn->len and key->len.
https://github.com/nginx/nginx/blob/dfe70f74a3558f05142fb552cea239add123d414/src/core/ngx_string.h#L17
OTOH, ngx_read_file returns the value which type is ssize_t, it should realize casting safty between ssize_t and size_t
in ngx_http_vhost_traffic_status_dump_restore.
FYI: https://stackoverflow.com/questions/16086331/cast-ssize-t-or-size-t