Add tests for GPU accounting and fix parsing sinfo output #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes make accounting work with slurm 19 and should help with vpenso#38
itzsimpl
reviewed
Feb 3, 2022
| func ParseAllocatedGPUs() float64 { | ||
| var num_gpus = 0.0 | ||
|
|
||
| func getSacctData() []byte { | ||
| args := []string{"-a", "-X", "--format=Allocgres", "--state=RUNNING", "--noheader", "--parsable2"} |
There was a problem hiding this comment.
Note that in SLURM 20.11+ Allocgres is deprecated, consider changing to AllocTRES like in #34, or to make it version independent fist check if sacct --helpformat returns AllocGRES as a possible value.
There was a problem hiding this comment.
I am aware of that. However, since I don't have a slurm v20 cluster, I'm not risking changing the code myself to make it compatible with that version. Instead, I'm adding tests for the current code which should make it easier to add support for slurm 20 later (e.g. in another PR).
|
friendly ping @vpenso @mtds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make GPU accounting work with slurm 19 (at least for my installation) and should help with testing different outputs in #38.
The sinfo parsing change is from #38 (comment).
Please let me know if I should add a copyright/licence header to the new files.