Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#62: Fix M244 compatibility, removed legacy text from readme #63

Merged
merged 1 commit into from
Aug 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Helper/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public function getAllowedIps($separator=false)
{
$allowedIps = $this->getConfig('dev/quickdevbar/allow_ips');
if($allowedIps) {
$allowedIps = preg_split('#\s*,\s*#', $allowedIps, null, PREG_SPLIT_NO_EMPTY);
$allowedIps = preg_split('#\s*,\s*#', $allowedIps, -1, PREG_SPLIT_NO_EMPTY);
} else {
$allowedIps = array();
}
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ php bin/magento cache:flush

The toolbar is displayed by default if your web server is on your local development environment.

The configuration is in Stores/Configuration/Advanced/Developer/Quick dev bar configuration
![](doc/images/qdb_screen_config_ok.png)
The configuration is in Stores/Configuration/Advanced/Developer/Quick dev bar configuration.

If you do not see the toolbar you should either force activation by setting the select "Activate" to "Yes" or fill your IP in the field "Allowed IPs" or fill a matching pattern of you user-agent in the field "Allowed user-agent pattern"

If you do not see the toolbar you should either force activation by filling your IP in the field "Allowed IPs" and fill a matching pattern of you user-agent in the field "Allowed user-agent pattern" if it's needed.
![](doc/images/qdb_screen_config_ko.png)

# Documentation
Expand Down
Binary file removed doc/images/qdb_screen_config_ok.png
Binary file not shown.