Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RGB24Depth adjustment #12

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fixed RGB24Depth adjustment #12

merged 1 commit into from
Feb 22, 2024

Conversation

mkalkbrenner
Copy link
Collaborator

No description provided.

@mkalkbrenner
Copy link
Collaborator Author

The current code only applied the custom depth to one third of the pixels. This patch basically reverts the change @toxieainc introduced and @jsm174 tried to fix.

@jsm174 jsm174 merged commit 531516f into vpinball:master Feb 22, 2024
11 checks passed
@toxieainc
Copy link
Member

toxieainc commented Feb 22, 2024

I'm still confused about this one.
So the code at https://github.com/PPUC/libdmdutil/blob/fdfdb4c6a67a1a3c80a855c2206c3cbb8f7ff269/src/DMD.cpp#L946 really has to consume width x height x 3 x 3 bytes from pData?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants