Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls #220

Closed
purva-thakre opened this issue Nov 8, 2023 · 3 comments · Fixed by #338
Closed

Remove coveralls #220

purva-thakre opened this issue Nov 8, 2023 · 3 comments · Fixed by #338
Assignees

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Nov 8, 2023

coveralls is listed as a dependency in the toml file.

But this package is not compatible with py>3.10.
https://github.com/TheKevJames/coveralls-python#coveralls-for-python

image

Probably why a warning is raised by pytest in the 3.11 workflow?

https://github.com/vprusso/toqito/actions/runs/6800993611/job/18490827614?pr=212#step:5:668

../../../.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/coverage/pytracer.py:223
  /home/runner/.cache/pypoetry/virtualenvs/toqito-QfgmswsN-py3.11/lib/python3.11/site-packages/coverage/pytracer.py:223: DeprecationWarning: currentThread() is deprecated, use current_thread() instead
    self.thread = self.threading.currentThread()
@purva-thakre purva-thakre self-assigned this Nov 8, 2023
@purva-thakre
Copy link
Collaborator Author

probably related to #218.

@vprusso
Copy link
Owner

vprusso commented Nov 8, 2023

Hmm, I think we can probably remove the coveralls dependencies and usage. It looks like the package isn't well-maintained and hasn't been updated in some time.

Perhaps we can stick with codecov (similarly to how it was done in mitiq?):
unitaryfund/mitiq#301

Any thoughts, @purva-thakre ?

@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Nov 8, 2023

@vprusso I am fine with using codecov. Saves me the work of searching for replacements. thanks!

https://docs.codecov.com/docs#step-1-sign-up-for-codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants