Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls #338

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Remove coveralls #338

merged 2 commits into from
Dec 7, 2023

Conversation

purva-thakre
Copy link
Collaborator

Description

Fixes #220

The changes in this PR follow from https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage#create-ci-pipeline

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2226c46) 97.2% compared to head (7f2a752) 97.2%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #338   +/-   ##
======================================
  Coverage    97.2%   97.2%           
======================================
  Files         152     152           
  Lines        3046    3046           
  Branches      726     726           
======================================
  Hits         2961    2961           
  Misses         50      50           
  Partials       35      35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre marked this pull request as ready for review December 7, 2023 01:18
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Dec 7, 2023

@vprusso marking this ready for a review. I don't really think I had to do a lot here considering codecov was already being used here. Coveralls was installed but not used by anything.

The existing workflow was pretty similar to what codecov needs https://github.com/codecov/codecov-action?tab=readme-ov-file#example-workflowyml-with-codecov-action

Are we even using coverage.xml ? I personally don't see the difference between only xml and specifying coverage.xml. The coverage was still uploaded as expected.

image

Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@purva-thakre purva-thakre merged commit 52ecb1c into master Dec 7, 2023
@purva-thakre purva-thakre deleted the remove_coveralls branch December 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove coveralls
2 participants