Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qiskit as dependency #818

Closed
vprusso opened this issue Oct 2, 2024 · 2 comments · Fixed by #842
Closed

Remove Qiskit as dependency #818

vprusso opened this issue Oct 2, 2024 · 2 comments · Fixed by #842
Assignees
Labels
Milestone

Comments

@vprusso
Copy link
Owner

vprusso commented Oct 2, 2024

The only place in which the Qiskit package is used is in:
https://github.com/vprusso/toqito/blob/master/toqito/rand/random_states.py

This seems a bit of an excessive dependency for such a small amount of usage. Indeed, the random generation of the state vector should probably just be imported wholesale within this function as they do in the random_statevector function from Qiskit:
https://github.com/Qiskit/qiskit/blob/main/qiskit/quantum_info/states/random.py

Then the Qiskit dependency could be removed.

@vprusso vprusso added good first issue Good for newcomers non-quantum labels Oct 2, 2024
@tnemoz
Copy link
Contributor

tnemoz commented Oct 2, 2024

I don't mind doing it, it seems like it shouldn't take long. Or is it better to leave the "good first issue" issues alone for now, in case someone else would like to give it a shot?

@purva-thakre
Copy link
Collaborator

@tnemoz I think this issue and #820 are closely related. If you want to create 1 PR to fix both, feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants