Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inner_product and outer_product functions #830

Closed
vprusso opened this issue Oct 5, 2024 · 0 comments · Fixed by #833
Closed

Remove inner_product and outer_product functions #830

vprusso opened this issue Oct 5, 2024 · 0 comments · Fixed by #833
Assignees
@vprusso
Labels
good first issue Good for newcomers non-quantum refactor
Milestone
v1.1.1

Comments

@vprusso
Copy link
Owner

vprusso commented Oct 5, 2024

As these functions are simply just wrappers for numpy functions, it seems redundant to have these included within toqito as glorified wrapper functions. We should likely remove these functions and simply invoke either np.vdot or np.outer where appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vprusso vprusso

Labels
good first issue Good for newcomers non-quantum refactor
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging a pull request may close this issue.

Removed inner and outer product functions. vprusso/toqito
2 participants
@vprusso @purva-thakre