Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inner and outer product functions. #833

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Oct 6, 2024

Closes: #830

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.9%. Comparing base (b07993c) to head (c0df19a).
Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
toqito/matrix_props/sk_norm.py 50.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #833   +/-   ##
======================================
  Coverage    97.8%   97.9%           
======================================
  Files         168     166    -2     
  Lines        3259    3249   -10     
  Branches      800     798    -2     
======================================
- Hits         3189    3181    -8     
+ Misses         46      44    -2     
  Partials       24      24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre
Copy link
Collaborator

@vprusso The portion for removing inner and outer product functions looks good to me.

I'll take some time going over the sk_norm portion. Looks like you are also using this PR to fix #242.

@vprusso
Copy link
Owner Author

vprusso commented Oct 11, 2024

@vprusso The portion for removing inner and outer product functions looks good to me.

I'll take some time going over the sk_norm portion. Looks like you are also using this PR to fix #242.

@purva-thakre Yep, I added a few additional tests for coverage here in this PR. Part of the reason for that was the covbot thought somehow that removing those two functions reduced the overall test coverage, so I needed to up the coverage a bit by adding those lines. Kind of annoying, but I suppose more coverage isn't a bad thing!

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Apologies for the delay.

@vprusso vprusso merged commit d3323af into master Oct 22, 2024
18 checks passed
@vprusso vprusso deleted the 830-remove-inner-outer-product branch October 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inner_product and outer_product functions
2 participants