Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pure_to_mixed in favor of vector_to_density_matrix #847

Closed
vprusso opened this issue Oct 9, 2024 · 5 comments · Fixed by #853
Closed

Remove pure_to_mixed in favor of vector_to_density_matrix #847

vprusso opened this issue Oct 9, 2024 · 5 comments · Fixed by #853
Labels
enhancement New feature or request good first issue Good for newcomers refactor
Milestone

Comments

@vprusso
Copy link
Owner

vprusso commented Oct 9, 2024

In favor of both pure_to_mixed and vector_to_density_matrix being functionally equivalent, it may make sense to do the following:

  1. Remove the pure_to_mixed function (along with the associated tests)
  2. Replace any usages of pure_to_mixed with vector_to_density_matrix.
  3. Rename vector_to_density_matrix to just to_density_matrix as the input does not necessarily need to be a vector (indeed, it can even be a density matrix) so it may be misleading to prefix the name with vector (and hence should drop).
@vprusso vprusso added enhancement New feature or request good first issue Good for newcomers refactor labels Oct 9, 2024
@mhaoda
Copy link
Contributor

mhaoda commented Oct 10, 2024

I'm a quite new contributor to opensource. I want to try a simple issue at the beginning, can I work on this?

@purva-thakre
Copy link
Collaborator

Hi @mhaoda, I think it might be better to pick a different issue. Someone else (@Shivansh20128) is interested in fixing this issue as they pointed out the the stuff in the description in the toqito Discord channel.

Good to know you are a new contributor! @vprusso or I could walk you through the steps to resolve a different issue.

@mhaoda
Copy link
Contributor

mhaoda commented Oct 11, 2024

Thanks so much @purva-thakre, I'm totally willing to look at a different issue, could you please provide more information about it?

@vprusso
Copy link
Owner Author

vprusso commented Oct 11, 2024

Appreciate your enthusiasm, @mhaoda !

Depending on @Shivansh20128 's inclinations, we can see if they are planning on tackling this. Alternatively, any of the other issues on the board that have the "good-first-issue" tag are typically low barrier-to-entry tasks that are good entry points to the project. I intend on continuing to add more issues with this tag as well, so do stay tuned.

If you like, I can tag you on other issues that I put up that might be good candidates for you if you are interested. Let me know, as I don't want to spam you needlessly! :)

@Shivansh20128
Copy link
Contributor

Hi! Yes, I will work on this issue after finishing the previous one. I am very close to completing it.
Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers refactor
Projects
None yet
4 participants