Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor partial_trace and partial_transpose #158

Merged
merged 4 commits into from
Jun 4, 2023
Merged

Refactor partial_trace and partial_transpose #158

merged 4 commits into from
Jun 4, 2023

Conversation

ErikQQY
Copy link
Contributor

@ErikQQY ErikQQY commented May 29, 2023 •
edited
Loading

Description

Fix: #145
This PR refactored partial_trace and partial_transpose.

Status

  • Ready to go

@ErikQQY
Refactor partial_trace and partial_transpose
03d5d1c 
Signed-off-by: ErikQQY <2283984853@qq.com>
@ErikQQY
partail_trace done
7519371 
Signed-off-by: ErikQQY <2283984853@qq.com>
@ErikQQY
Done refactoring
7fda5b7 
Signed-off-by: ErikQQY <2283984853@qq.com>
@ErikQQY
Copy link
Contributor Author

ErikQQY commented Jun 3, 2023

@vprusso I think this PR is ready to go!!

vprusso
vprusso reviewed Jun 3, 2023
View reviewed changes
Copy link
Owner

@vprusso vprusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Adding a few minor comments. Let me know if you have any questions and we can hash it out!

@ErikQQY

tests/test_channels/test_partial_transpose.py Show resolved Hide resolved
tests/test_channels/test_partial_transpose.py Show resolved Hide resolved
tests/test_channels/test_partial_trace.py Show resolved Hide resolved
tests/test_state_props/test_is_separable.py Outdated Show resolved Hide resolved
tests/test_state_props/test_is_separable.py Outdated Show resolved Hide resolved
@ErikQQY
Fix non-square test and wrong import
ba67c16 
Signed-off-by: ErikQQY <2283984853@qq.com>
@vprusso
Copy link
Owner

vprusso commented Jun 3, 2023

Awesome, thanks for making the changes! I think this diff looks good to go on my end. If you agree, I'll go ahead and merge, but wanted to check with you beforehand. @ErikQQY

@ErikQQY
Copy link
Contributor Author

ErikQQY commented Jun 4, 2023

Let’s go!!

@vprusso vprusso merged commit 16d693c into vprusso:master Jun 4, 2023
@vprusso
Copy link
Owner

vprusso commented Jun 4, 2023

Awesome! Thank you again @ErikQQY for your contribution!

@vprusso vprusso mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprusso vprusso vprusso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Partial trace and partial transpose
2 participants
@ErikQQY @vprusso