Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnall dominant #176

Merged
merged 16 commits into from
Jun 13, 2023
Merged

Diagnall dominant #176

merged 16 commits into from
Jun 13, 2023

Conversation

elads888
Copy link
Contributor

Description

modified PR to be up to date, and changed code according to comments.
Hope this is good.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

elads888 and others added 15 commits June 9, 2023 09:28
vprusso
vprusso requested changes Jun 11, 2023
View reviewed changes
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment about test coverage, but overall looks really good! Once that's addressed, I think we can move this over the line. Let me know if you have any questions!

@elads888
Copy link
Contributor Author

Hi Vincenct!
Added the new tests, Hope we can move it over the line.

@vprusso vprusso merged commit beac8a1 into vprusso:master Jun 13, 2023
@vprusso vprusso mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprusso vprusso vprusso requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elads888 @vprusso