Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage for channel_fidelity #232

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Nov 13, 2023

Description

Fixes #231

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #232 (9679322) into master (a929bb0) will increase coverage by 0.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #232     +/-   ##
========================================
+ Coverage    96.0%   96.4%   +0.3%     
========================================
  Files         146     146             
  Lines        2956    2956             
  Branches      728     728             
========================================
+ Hits         2840    2851     +11     
+ Misses         71      61     -10     
+ Partials       45      44      -1     
Files Coverage Δ
toqito/channel_metrics/channel_fidelity.py 100.0% <100.0%> (+57.8%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@vprusso
Copy link
Owner

vprusso commented Nov 13, 2023

I believe the channel_fidelity.py function should use the partial trace function from toqito instead of the one it's currently using from picos. Then, the commented out functions intest_channel_fidelity.py can be uncommented and be run (which would then increase the coverage). Does that make sense?

@purva-thakre
Copy link
Collaborator Author

I believe the channel_fidelity.py function should use the partial trace function from toqito instead of the one it's currently using from picos. Then, the commented out functions intest_channel_fidelity.py can be uncommented and be run (which would then increase the coverage). Does that make sense?

Thanks! Makes sense.

@purva-thakre purva-thakre marked this pull request as ready for review November 13, 2023 19:56
@purva-thakre purva-thakre requested a review from vprusso November 13, 2023 20:02
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like how the tests are also simpler from your changes as well. LGTM! Approved!

@purva-thakre purva-thakre merged commit 79c309f into master Nov 13, 2023
@purva-thakre purva-thakre deleted the pytest_channel_fidelity branch November 13, 2023 22:37
vprusso pushed a commit that referenced this pull request Nov 15, 2023
* check ValueError missing

* uncomment failing tests + change import path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for toqito/channel_metrics/channel_fidelity.py : 82-97, 79->82
2 participants