Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Coverage: kp_norm #246

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Pytest Coverage: kp_norm #246

merged 8 commits into from
Nov 17, 2023

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Nov 15, 2023

Description

Fixes #245

Fixes #238

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1df0eb6) 96.4% compared to head (ba7a447) 96.5%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #246   +/-   ##
======================================
  Coverage    96.4%   96.5%           
======================================
  Files         146     146           
  Lines        2956    2955    -1     
  Branches      728     728           
======================================
+ Hits         2852    2853    +1     
+ Misses         60      59    -1     
+ Partials       44      43    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre
Copy link
Collaborator Author

Pylint has flagged some issues after some changes in 2fd4dae. This PR could be used to correct these.

************* Module tests.test_state_props.test_schmidt_rank
tests/test_state_props/test_schmidt_rank.py:44:4: W0621: Redefining name 'e_0' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:44:9: W0621: Redefining name 'e_1' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:58:4: W0621: Redefining name 'e_0' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:58:9: W0621: Redefining name 'e_1' from outer scope (line 9) (redefined-outer-name)

@vprusso
Copy link
Owner

vprusso commented Nov 15, 2023

Pylint has flagged some issues after some changes in 2fd4dae. This PR could be used to correct these.

************* Module tests.test_state_props.test_schmidt_rank
tests/test_state_props/test_schmidt_rank.py:44:4: W0621: Redefining name 'e_0' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:44:9: W0621: Redefining name 'e_1' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:58:4: W0621: Redefining name 'e_0' from outer scope (line 9) (redefined-outer-name)
tests/test_state_props/test_schmidt_rank.py:58:9: W0621: Redefining name 'e_1' from outer scope (line 9) (redefined-outer-name)

Whoops, that is completely my fault. Thank you for flagging and catching that, @purva-thakre !

@purva-thakre purva-thakre marked this pull request as ready for review November 16, 2023 16:53
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but LGTM! MWR! 🚀

tests/test_matrix_props/test_kp_norm.py Show resolved Hide resolved
tests/test_state_props/test_schmidt_rank.py Outdated Show resolved Hide resolved
@purva-thakre purva-thakre merged commit d7c317f into master Nov 17, 2023
3 checks passed
@purva-thakre purva-thakre deleted the pytest_kp_norm branch November 17, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: The kp_norm function should live in matrix_props Add tests for toqito/helper/kp_norm.py: 20
2 participants