Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for linear independence. #324

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Dec 3, 2023

Closes #142

@vprusso vprusso requested a review from purva-thakre December 3, 2023 16:26
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ec4bf3) 98.2% compared to head (42cdcd1) 98.2%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #324   +/-   ##
======================================
  Coverage    98.2%   98.2%           
======================================
  Files         297     299    +2     
  Lines        6688    6697    +9     
  Branches      771     771           
======================================
+ Hits         6569    6578    +9     
  Misses         82      82           
  Partials       37      37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso vprusso added this to the Release 1.0.7 milestone Dec 4, 2023
@purva-thakre
Copy link
Collaborator

Something I recently caught wrt to the new additions, we do want to make sure we add them to the documentation. It's up to you if you want to use this PR for all of the previously merged PRs or create a separate PR.

this PR, #327, #274, #272

@vprusso
Copy link
Owner Author

vprusso commented Dec 5, 2023

Something I recently caught wrt to the new additions, we do want to make sure we add them to the documentation. It's up to you if you want to use this PR for all of the previously merged PRs or create a separate PR.

this PR, #327, #274, #272

Oof, very good call, thank you for flagging this!

I also missed trine and is_antidistinguishable as well. Added those (as well as the ones for is_linearly_independent).

Good call!

@vprusso vprusso merged commit ca9f6f1 into master Dec 5, 2023
@vprusso vprusso deleted the 142-check-for-linear-independent-vectors branch December 5, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Check for linearly independent / dependent vectors
2 participants