Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PPT and other misc. #469

Merged
merged 20 commits into from
Feb 14, 2024
Merged

Fixing PPT and other misc. #469

merged 20 commits into from
Feb 14, 2024

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Feb 11, 2024

  • Updating PPT code to use picos over cvxopt/cvxpy.
  • Fixing bug in calculate_vector_matrix_dimension
  • Adding vector_to_density_matrix function
  • Updating prior usage of pure_to_mixed to vector_to_density_matrix

@vprusso vprusso changed the title Draft: Fixing PPT and other misc. Fixing PPT and other misc. Feb 11, 2024
@vprusso vprusso marked this pull request as draft February 11, 2024 01:46
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfeae4f) 98.1% compared to head (c193430) 98.1%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #469   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         160     161    +1     
  Lines        3108    3096   -12     
  Branches      749     753    +4     
======================================
- Hits         3049    3038   -11     
  Misses         37      37           
+ Partials       22      21    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso vprusso requested a review from purva-thakre February 11, 2024 13:48
@vprusso vprusso marked this pull request as ready for review February 11, 2024 13:48
Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for some minor comments to tests, this PR is almost there!

You might see some comments related to toqito/state_opt/ppt_distinguishability.py later. I don't have the time to do a deep dive right now. I want to understand how the new changes are not flagged by pytest as uncovered by tests.

@vprusso
Copy link
Owner Author

vprusso commented Feb 12, 2024

@purva-thakre changes made. If they are good with you, feel free to lift the "changes requested" flag and I'll merge away. Thank you again!

@vprusso vprusso merged commit d059949 into master Feb 14, 2024
18 checks passed
@vprusso vprusso deleted the ppt-fix-vec-dm branch February 14, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants