-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing PPT and other misc. #469
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 160 161 +1
Lines 3108 3096 -12
Branches 749 753 +4
======================================
- Hits 3049 3038 -11
Misses 37 37
+ Partials 22 21 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for some minor comments to tests
, this PR is almost there!
You might see some comments related to toqito/state_opt/ppt_distinguishability.py
later. I don't have the time to do a deep dive right now. I want to understand how the new changes are not flagged by pytest
as uncovered by tests.
@purva-thakre changes made. If they are good with you, feel free to lift the "changes requested" flag and I'll merge away. Thank you again! |
Co-authored-by: Purva Thakre <66048318+purva-thakre@users.noreply.github.com>
Co-authored-by: Purva Thakre <66048318+purva-thakre@users.noreply.github.com>
picos
overcvxopt
/cvxpy
.calculate_vector_matrix_dimension
vector_to_density_matrix
functionpure_to_mixed
tovector_to_density_matrix