Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to punctuation and code rendering for documentation. #517

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Mar 24, 2024

I noticed a few areas in the docs that weren't rendering code correctly and also fixing some minor punctuation/grammar in docs.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (6500384) to head (bfcf19b).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #517   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         160     160           
  Lines        3090    3090           
  Branches      751     751           
======================================
  Hits         3032    3032           
  Misses         37      37           
  Partials       21      21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso
Copy link
Owner Author

vprusso commented Mar 24, 2024

@purva-thakre
Copy link
Collaborator

purva-thakre commented Mar 25, 2024

Think we've seen the failures

Yup, there's an open issue for these. #473

The failing tests should pass if you re-run the workflow a couple of times.

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these!

@vprusso vprusso merged commit 2714b92 into master Mar 25, 2024
18 checks passed
@vprusso vprusso deleted the fix-code-docs-rendering branch March 25, 2024 13:58
@purva-thakre purva-thakre added this to the v1.0.8 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants