Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor antisymmetric_projection #523

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Mar 29, 2024

Description

Closes: #498

Changes

  • Refactor antisymmetric_projection.py
  • Update test_antisymmetric_projection.py

Checklist

  • Use ruff and pylint for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (2714b92) to head (39c6645).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #523     +/-   ##
========================================
- Coverage    98.1%   98.1%   -0.1%     
========================================
  Files         160     160             
  Lines        3090    3088      -2     
  Branches      751     751             
========================================
- Hits         3032    3030      -2     
  Misses         37      37             
  Partials       21      21             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bchass Bchass marked this pull request as ready for review March 29, 2024 00:56
Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vprusso Did you have any additional comments?

@vprusso
Copy link
Owner

vprusso commented Apr 4, 2024

LGTM!

@vprusso Did you have any additional comments?

None on my side. I'll go ahead and merge. Thanks again, @Bchass !

@vprusso vprusso merged commit 0dc6d54 into vprusso:master Apr 4, 2024
32 of 34 checks passed
@Bchass Bchass deleted the ap_refactor branch April 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of toqito/perms/antisymmetric_projection.py is of type matrix
3 participants