Upated Indexing from 1 -> 0

[anushkrishnav]

Description

Fixes #168
Moving Permute system index offset from 0->1

Changes

Update the code

the docs and tests would be updated once the solution is approved

Checklist

• Use ruff for errors related to code style and formatting.
• Verify all previous and newly added unit tests pass in pytest.
• Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
• Use linkcheck to check for broken links in the documentation
• Use doctest to verify the examples in the function docstrings work as expected.

[purva-thakre]

the docs and tests would be updated once the solution is approved

Can you go ahead and make changes to the unit tests and doc examples? It's difficult to see how the new changes would work successfully otherwise.

[anushkrishnav]

Yes I am on it right now
@purva-thakre
for some reason pytest throws the error below

_____________________________________________________________________________ ERROR collecting toqito/perms/tests/test_unique_perms.py _____________________________________________________________________________
ImportError while importing test module '/Users/anushkrishnav/Documents/toqito/toqito/perms/tests/test_unique_perms.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/homebrew/Cellar/python@3.11/3.11.9/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
toqito/perms/__init__.py:3: in <module>
    from toqito.perms.unique_perms import unique_perms
E   ModuleNotFoundError: No module named 'toqito'

[anushkrishnav]

fixed it by setting
PYTHONPATH=. pytest

[purva-thakre]

fixed it by setting PYTHONPATH=. pytest

This depends on how your local virtual environment is setup.

[anushkrishnav]

I have updated the tests, there is one case that's failing which is the 16x16 check part from that all the other cases are working well not sure whats going wrong, is there a way to verify what the right result would be ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (220b94f) to head (a0be190).
Report is 272 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #602   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files         162     162           
  Lines        3108    3112    +4     
  Branches      760     759    -1     
======================================
+ Hits         3050    3054    +4     
  Misses         37      37           
  Partials       21      21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[purva-thakre]

there is one case that's failing which is the 16x16 check part

Which one are you talking about? Can you link it?

[anushkrishnav]

there is one case that's failing which is the 16x16 check part

Which one are you talking about? Can you link it?

@purva-thakre Solved the problem, all cases have passed now, made a small mistake That I have fixed it , and the code should now work across all these cases, I have made the change in the codes that uses perm from 1 to do from 0 as well

[purva-thakre]

Getting close to merging this!

I suggested some minor changes and also requested a clarification on a change you made.

[anushkrishnav]

Will work on the change requests shortly , I think the comment was removed by mistake @purva-thakre

[vprusso]

Great, thanks for continuing to work on those changes, and feel free to let us know if you have any additional questions, @anushkrishnav !

[anushkrishnav]

Great, thanks for continuing to work on those changes, and feel free to let us know if you have any additional questions, @anushkrishnav !

No problem, I am just waiting for the review, It was fun working !

[purva-thakre]

Congrats on the bounty @anushkrishnav !

[anushkrishnav]

Congrats on the bounty @anushkrishnav !

Thank you !!!