Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed lil sparse matrix for GHZ state. #637

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

vprusso
Copy link
Owner

@vprusso vprusso commented Jun 24, 2024

Closes: #536

  • Removed sparse.lil_matrix from ghz.py
  • Updated tests and docs (no longer need to use .toarray().

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.6%. Comparing base (c6a7f2d) to head (0e4b665).
Report is 270 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #637     +/-   ##
========================================
- Coverage    97.6%   97.6%   -0.1%     
========================================
  Files         162     162             
  Lines        3215    3212      -3     
  Branches      787     787             
========================================
- Hits         3141    3138      -3     
  Misses         48      48             
  Partials       26      26             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vprusso vprusso merged commit c826b57 into master Jun 24, 2024
18 checks passed
@vprusso vprusso deleted the 536-remove-lil-matrix-ghz branch June 24, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lil_matrix in toqito/states/ghz.py
2 participants