-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing redundant note for doctest. #651
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #651 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 166 166
Lines 3250 3250
Branches 795 795
======================================
Hits 3176 3176
Misses 48 48
Partials 26 26 ☔ View full report in Codecov by Sentry. |
I am fine with removing this if it is repeated across one page. We should mention it once for the other pages. The things required by |
That makes sense--I think having it at least in one place definitely makes sense. Maybe in the contribution guide? |
What if we create a section called Adding it to the contribution guide wouldn't be helpful for someone who is not interested in contributing to the project. Thoughts? |
>>> np.around(entanglement_of_formation(rho), decimals=2) | ||
1.00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> np.around(entanglement_of_formation(rho), decimals=2) | |
1.00 | |
>>> import numpy as np | |
>>> np.around(entanglement_of_formation(rho), decimals=2) | |
1.00 |
Sometimes np.around
will round up to a higher number when we don't want it to. We don't see that here but when a function relies on optimization, np.around(0.8)
gets rounded up to 1.0
. This is why I did not use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this would only occur if you don't specify the number of decimals.
So, for instance:
np.around(0.66)
1.0
However
np.around(0.66, decimals=2)
0.66
Closes #650