Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condense two nonnegative functions #731

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

purva-thakre
Copy link
Collaborator

Description

Based on the discussion in #723, this PR combines is_nonegative and is_doubly_nonnegative into 1 function.

Changes

Notable changes that this PR has either accomplished or will accomplish. Feel free to add more lines to the itemized list
below.

  • Change 1

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

@purva-thakre purva-thakre changed the title Condense two nonnegative functions into 1 Condense two nonnegative functions Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.7%. Comparing base (de9a087) to head (24ace04).
Report is 316 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #731     +/-   ##
========================================
- Coverage    97.7%   97.7%   -0.1%     
========================================
  Files         166     165      -1     
  Lines        3250    3245      -5     
  Branches      795     795             
========================================
- Hits         3177    3172      -5     
  Misses         48      48             
  Partials       25      25             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre marked this pull request as ready for review August 7, 2024 05:42
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but LGTM! Nice call on doing this given that the same was done for the stochastic case!

toqito/matrix_props/is_nonnegative.py Show resolved Hide resolved
@purva-thakre purva-thakre merged commit c662c1c into master Aug 7, 2024
18 checks passed
@purva-thakre purva-thakre deleted the condense_nonnegative branch August 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants